Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[toggleAutoSave]: Toggle Auto save doesn't go back to the selected mode (fix: #211538) #211544

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MohamedLamineAllal
Copy link

@MohamedLamineAllal MohamedLamineAllal commented Apr 27, 2024

Solve issue: #211538

  • Did use the StorageService to save the value. And use it from there.
  • By introducing the StorageService, i had to update the TestStorageService constructs in 2 other tests files

For Tests

No tests were implemented for the whole toggle functionality (my changes, and the changes before).

Otherwise, i did test the changes of this PR. And it does fix well the problem. Also all tests are passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants