add debug console accessible view #221398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connor4312
reviewed
Jul 10, 2024
Co-authored-by: Connor Peet <connor@peet.io>
connor4312
reviewed
Jul 10, 2024
connor4312
reviewed
Jul 10, 2024
connor4312
reviewed
Jul 10, 2024
connor4312
reviewed
Jul 11, 2024
src/vs/workbench/contrib/comments/browser/commentsAccessibleView.ts
Outdated
Show resolved
Hide resolved
connor4312
reviewed
Jul 11, 2024
src/vs/editor/contrib/inlineCompletions/browser/inlineCompletionsAccessibleView.ts
Outdated
Show resolved
Hide resolved
meganrogge
commented
Jul 11, 2024
src/vs/workbench/contrib/accessibility/browser/editorAccessibilityHelp.ts
Outdated
Show resolved
Hide resolved
|
cc @roblourens |
roblourens
reviewed
Jul 15, 2024
| let line = 0; | ||
| const content: string[] = []; | ||
| for (const e of elements) { | ||
| content.push(e.toString().replace(/\n/g, '')); |
There was a problem hiding this comment.
You might want to escape the newline rather than remove it, so they know there was a newline here?
There was a problem hiding this comment.
Not sure an empty line is useful to know about. It was messing up the line numbers. We'll see what testers and users say
There was a problem hiding this comment.
You can keep it a single line, I mean printing a\nb instead of ab which is deleting information
| @@ -639,7 +656,7 @@ export class Repl extends FilterViewPane implements IHistoryNavigationWidget { | |||
| new ReplRawObjectsRenderer(linkDetector, this.hoverService), | |||
| ], | |||
| // https://github.com/microsoft/TypeScript/issues/32526 | |||
| new ReplDataSource() satisfies IAsyncDataSource<IDebugSession, IReplElement>, | |||
| this.replDataSource, | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #213413
Remaining work to tackle in different PR / seeking feedback from users:
debug.autoExpandLazyVariablesfor screen reader users by default