Trigger chat variable completion on word start #224174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roblourens
reviewed
Jul 29, 2024
There was a problem hiding this comment.
Thanks for the PR! With this, if I have the cursor at the end or in the middle of a partial word, like #sele| or #s|ele where | marks the cursor, then I don't get completions. I think it should be checking for a word before #, not before the point where completions are requested.
|
@roblourens Right you are, changed it to use matched word start column |
|
With this change, if I just type |
bsShoham
force-pushed
the
dev/allow-completion-only-on-word-start
branch
from
14f8d5b
to
afd2186
Compare
|
fell for the classic off by 1 error, fixed and tested |
roblourens
approved these changes
Aug 1, 2024
Tyriar
approved these changes
Aug 1, 2024
BABA983
pushed a commit
to BABA983/vscode
that referenced
this pull request
Aug 2, 2024
* And to `computeCompletionRanges` support for allowing completions only on word start * use word start column instead of cursor position * Fix wrong column number
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #216757
Added optional boolean parameter to
computeCompletionRangescalledonlyOnWordStart, which dictates to return the range only if the foundvarWordis at word start.Set it as true on chat input variable completion (
#)