Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 include setext heading levels (Markdown) #32987

Merged
merged 3 commits into from
Aug 23, 2017
Merged

🐛 include setext heading levels (Markdown) #32987

merged 3 commits into from
Aug 23, 2017

Conversation

yzhang-gh
Copy link
Contributor

Fix #32859 and at the same time #32844 (Markdown slugify misses backticks).

@msftclas
Copy link

@neilsustc,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@yzhang-gh yzhang-gh changed the title 🐛 include setext heading levels 🐛 include setext heading levels (Markdown) Aug 22, 2017
@yzhang-gh yzhang-gh mentioned this pull request Aug 22, 2017
Closed
@mjbvz
Copy link
Collaborator

mjbvz commented Aug 23, 2017

Thanks! Looks like there is a small compile error:

Error: C:/projects/vscode/extensions/markdown/src/tableOfContentsProvider.ts(57,64): Property 'markup' does not exist on type 'Token[]'.

@mjbvz mjbvz self-assigned this Aug 23, 2017
@mjbvz mjbvz self-requested a review August 23, 2017 00:07
@mjbvz mjbvz added this to the August 2017 milestone Aug 23, 2017
@yzhang-gh
Copy link
Contributor Author

Updated. It's because I used the wrong var name 😅

mjbvz
mjbvz reviewed Aug 23, 2017
View reviewed changes
extensions/markdown/src/tableOfContentsProvider.ts Outdated
@@ -65,14 +68,24 @@ export class TableOfContentsProvider {
return toc;
}

private static getHeaderLevel(markup: string): number {
if (markup == '=') {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two comparisons need to use ===. I think this is what is causing the Travis build to fail

@mjbvz mjbvz merged commit 1c6f2f9 into microsoft:master Aug 23, 2017
@mjbvz
Copy link
Collaborator

mjbvz commented Aug 23, 2017

Thanks! The change should be in the next insiders build

@mjbvz mjbvz mentioned this pull request Aug 23, 2017
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mjbvz mjbvz mjbvz left review comments

Assignees

@mjbvz mjbvz

Labels
None yet
Projects
None yet
Milestone
August 2017
Development

Successfully merging this pull request may close these issues.

API: (built-in Markdown extension) interface TocEntry should have level as an attribute
3 participants
@yzhang-gh @msftclas @mjbvz