Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set background-color explicitly instead of shorthand declaration #47752 #47785

Merged
merged 1 commit into from
Apr 13, 2018
Merged

set background-color explicitly instead of shorthand declaration #47752 #47785

merged 1 commit into from
Apr 13, 2018

Conversation

fmal
Copy link
Contributor

@fmal fmal commented Apr 12, 2018

see #47752. background shorthand has a side effect of setting all background properties including resetting background-image, which is set for dirty tabs.

Before:
screen shot 2018-04-13 at 00 08 07

After:
screen shot 2018-04-13 at 00 08 46

@bpasero bpasero self-assigned this Apr 13, 2018
@bpasero bpasero added this to the April 2018 milestone Apr 13, 2018
@bpasero
Copy link
Member

bpasero commented Apr 13, 2018

@fmal thanks 🥂

@bpasero bpasero merged commit 70f47d4 into microsoft:master Apr 13, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@bpasero bpasero

Labels
None yet
Projects
None yet
Milestone
April 2018
Development

Successfully merging this pull request may close these issues.
2 participants
@fmal @bpasero