Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuickPick does not read out placeholder #51824

Closed
AccessibilityTestingTeam-TCS opened this issue Jun 14, 2018 · 14 comments
Closed

QuickPick does not read out placeholder #51824

AccessibilityTestingTeam-TCS opened this issue Jun 14, 2018 · 14 comments
Assignees
Labels
a11ymas Issue from accessibility team accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues *duplicate Issue identified as a duplicate of another issue(s) quick-pick Quick-pick widget issues windows VS Code on Windows issues

Comments

@AccessibilityTestingTeam-TCS

Environment Details:
VSCode Version : 1.24.1
OS Version : Win10

Additional Details:
NVDA 2018.2,JAWS18.0.5038,MAS1.3.1
same issue is observed in JAWS

Repro Steps:
1)Launch VSCode.
2)Navigate to Settings icon in Activity Bar->Press Enter->Select "Color Theme" from dropdown.
3)Check with NVDA reading.

Actual:
NVDA does not read the placeholder present on the screen.

Expected:
NVDA should read the placeholder which is present on the screen.

Recommendations:
Refer below link which is repository of bug fixes code snippets:
[https://microsoft.sharepoint.com/teams/msenable/mas/pages/browse-fixes.aspx

](url)

[User] Impact:
User will not able to know that there is placeholder present on the screen.

MAS Reference:
https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={8492c4eb-c179-40ae-8777-cd044ed725a2}

Attachment for Reference:
[Accessibility]A11y_VSCode_ColorTheme_Screenreade.pptx

Does this issue occur when all extensions are disabled?: Yes

@vscodebot
Copy link

vscodebot bot commented Jun 14, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@Tyriar Tyriar added the accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues label Jun 14, 2018
@RMacfarlane RMacfarlane added the quick-pick Quick-pick widget issues label Jun 14, 2018
@isidorn isidorn added the windows VS Code on Windows issues label Jul 3, 2018
@isidorn isidorn changed the title [Accessibility]A11y_VSCode_ColorTheme_Screenreader: NVDA does not read the placeholder present on the screen. QuickPick does not read out placeholder Jul 3, 2018
@isidorn
Copy link
Contributor

isidorn commented Jul 3, 2018

This works fine on mac with VoiceOver, but not on windows.
Not sure if this is low hanging fruit, leaving to @chrmarti and @bpasero to decide

@bpasero
Copy link
Member

bpasero commented Jul 4, 2018

That sounds like a bug in NVDA to me, but maybe we can tweak the ARIA label for inputs. We could also see if there is a aria-placeholder attribute to use but then we should use it everywhere.

@isidorn
Copy link
Contributor

isidorn commented Sep 20, 2018

@bpasero would you be willing to do some tweaking for this?
We need it for a better accessibility grade.
Anyways assigning to October so Christof looks once he is back if you do not have time this week

@isidorn isidorn added this to the October 2018 milestone Sep 20, 2018
@bpasero
Copy link
Member

bpasero commented Sep 21, 2018

I looked into it and have not good explanation for the behaviour. This seems to be triggered by the fact that the input box has a aria-activedescendant pointing to a tree/list item below. If I remove that, the placeholder is correctly announced.

Our only hope may be to announce the placeholder using aria.alert() which is ugly too.

We always used the aria-activedescendant trick since the beginning and I cannot remember we had this issue before so we could also try to reach out to NVDIA folks (@alexandrudima I think you did that for the editor a while ago, maybe you know the name still)

@isidorn
Copy link
Contributor

isidorn commented Sep 21, 2018

@bpasero you can always reach out to this repo here https://github.com/nvaccess/nvda
Or just find the top commiter and ping him here :)

@chrmarti chrmarti added the bug Issue identified by VS Code Team member as probable bug label Sep 24, 2018
@chrmarti
Copy link
Contributor

This works for me with QuickOpen, but not with QuickInput. Both use aria-activedescendant, I wonder what the difference is.

@bpasero
Copy link
Member

bpasero commented Sep 25, 2018

@chrmarti maybe tree vs list ARIA roles?

@isidorn
Copy link
Contributor

isidorn commented Sep 25, 2018

Yes might be. @chrmarti not that I changed one of them to use listitem which might be a bad change. Now I am checking the behavior on windows actually..

@chrmarti
Copy link
Contributor

You're right, with your change reverted it no longer works with QuickOpen.

@chrmarti
Copy link
Contributor

Not focusing any element in the list lets it read the placeholder. This was supposed to be fixed with #57501 which checks if it is in screen reader mode before setting the focus, but there is a bug that still makes it focus an element in most cases. Will fix.

@chrmarti
Copy link
Contributor

Actually should have worked before when screen reader mode was on. Closing as duplicate.

@chrmarti
Copy link
Contributor

/duplicate #57501

@vscodebot vscodebot bot added the *duplicate Issue identified as a duplicate of another issue(s) label Sep 26, 2018
@vscodebot
Copy link

vscodebot bot commented Sep 26, 2018

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Sep 26, 2018
@chrmarti chrmarti added a11ymas Issue from accessibility team and removed bug Issue identified by VS Code Team member as probable bug labels Sep 26, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 10, 2018
@isidorn isidorn added macos Issues with VS Code on MAC/OS X and removed macos Issues with VS Code on MAC/OS X labels Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a11ymas Issue from accessibility team accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues *duplicate Issue identified as a duplicate of another issue(s) quick-pick Quick-pick widget issues windows VS Code on Windows issues
Projects
None yet
Development

No branches or pull requests

6 participants