Fix dirty setting update logic #58926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Dirty setting will update when focused with a higher debounce * Dirty setting will immediately update when blurred
roblourens
reviewed
Sep 20, 2018
|
I'm not sure, I liked the comment that only text setting updates should have a slow debounce, and other types should be committed as fast as possible. What do you think? Should we send the type with onDidChangeSetting, and debounce differently based on the type? |
* Added a new enum for setting types * Added separate `Delayer` with a long debounce for non-text inputs
guywaldman
commented
Sep 20, 2018
guywaldman
commented
Sep 20, 2018
|
@roblourens Updated :) |
roblourens
reviewed
Sep 21, 2018
src/vs/workbench/services/preferences/common/preferencesModels.ts
Outdated
Show resolved
Hide resolved
roblourens
reviewed
Sep 21, 2018
|
@roblourens Just making sure - CI build for latest commit says unit tests are failing on Linux, but it seems that the problem is not with my changes. Is it OK? |
|
Yeah I checked it out and it looked like a flaky test 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #58537.
Setting that are dirty will now update: