Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dirty setting update logic #58926

Merged
merged 8 commits into from
Sep 21, 2018
Merged

Fix dirty setting update logic #58926

merged 8 commits into from
Sep 21, 2018

Commits on Sep 19, 2018

  1. Fix dirty setting update logic 

    * Dirty setting will update when focused with a higher debounce
* Dirty setting will immediately update when blurred
    @guywaldman
    guywaldman committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    471204f View commit details
    Browse the repository at this point in the history

  2. Add test

    @guywaldman
    guywaldman committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    b44b373 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2018

  1. Remove redundant async

    @guywaldman
    guywaldman committed Sep 20, 2018
    Configuration menu
    Copy the full SHA
    6855b54 View commit details
    Browse the repository at this point in the history

  2. Change behavior for non-text inputs 

    * Added a new enum for setting types
* Added separate `Delayer` with a long debounce for non-text inputs
    @guywaldman
    guywaldman committed Sep 20, 2018
    Configuration menu
    Copy the full SHA
    6bc7ce6 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2018

  1. Fix negated logic

    @guywaldman
    guywaldman committed Sep 21, 2018
    Configuration menu
    Copy the full SHA
    26f3dcc View commit details
    Browse the repository at this point in the history

  2. Stop updating setting on blur

    @guywaldman
    guywaldman committed Sep 21, 2018
    Configuration menu
    Copy the full SHA
    b1b3db9 View commit details
    Browse the repository at this point in the history

  3. Scope enum for settings more closely

    @guywaldman
    guywaldman committed Sep 21, 2018
    Configuration menu
    Copy the full SHA
    83dccc6 View commit details
    Browse the repository at this point in the history

  4. Remove Delayer.fire

    @guywaldman
    guywaldman committed Sep 21, 2018
    Configuration menu
    Copy the full SHA
    b5865f6 View commit details
    Browse the repository at this point in the history