Remove built-in toml basic language support (release/1.28) #59775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverts microsoft#59089 After further discussions with the team, we decided that we should not ship a bundled toml grammar. There are two reasons for this: * For the best toml experiance, users should use one of the toml plugins from the marketplace as these provide intellisense and other advanced language features. We previously recommend these plugins when you opened a toml file. However if we ship a bundled toml grammar, these recommendations will no longer appear * Engineering maintance costs on our side. Updating the grammar, maintaining tests, and handling issues related to it are all extra work that has to be considered. For these reasons, we do not think it makes sense to include basic toml support
kieferrm
approved these changes
Oct 1, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick of f2f8b7c for release 1.28