Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove built-in toml basic language support (release/1.28) #59775

Merged
merged 1 commit into from
Oct 1, 2018
Merged

Remove built-in toml basic language support (release/1.28) #59775

merged 1 commit into from
Oct 1, 2018

Commits on Oct 1, 2018

  1. Remove built-in toml basic language support 

    Reverts microsoft#59089

After further discussions with the team, we decided that we should not ship a bundled toml grammar. There are two reasons for this:

* For the best toml experiance, users should use one of the toml plugins from the marketplace as these provide intellisense and other advanced language features. We previously recommend these plugins when you opened a toml file. However if we ship a bundled toml grammar, these recommendations will no longer appear

* Engineering maintance costs on our side. Updating the grammar, maintaining tests, and handling issues related to it are all extra work that has to be considered.

For these reasons, we do not think it makes sense to include basic toml support
    @mjbvz
    mjbvz committed Oct 1, 2018
    Configuration menu
    Copy the full SHA
    8751c28 View commit details
    Browse the repository at this point in the history