updated preinstall to require node 9 and above. #68826
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
builds are now using node 10. With the dependencies updated, tests pass with node 9 and 10.
|
I posted this PR because I tried node 8 (as specified in the dev wiki), and dependencies would not install when invoking Yarn. |
|
I have a sister PR for the wiki here: microsoft/vscode-wiki#106 |
|
@toumorokoshi Everybody from our team was using node 8 up until last week ~ Thursday. I don't think we no longer work with node 8. What was the exact error you got? |
|
Nevermind, this looks to be my node minor version (8.9) conflicting with eslint. Eslint 5.2 requires node 8.10 and above. still might be worth checking, but the build does pass if I upgrade node. Sorry about the false alarm! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
builds are now using node 10. With the dependencies updated, tests pass with node 9 and 10.