Preselect default formatter #73535
Merged
Preselect default formatter #73535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrieken
requested changes
May 11, 2019
| @@ -209,11 +209,14 @@ async function showFormatterPick(accessor: ServicesAccessor, model: ITextModel, | |||
| }; | |||
| }); | |||
|
|
|||
| // auto focus the default formatter | |||
| let autoFocusItem = picks.filter((pick) => pick.description)[0]; | |||
There was a problem hiding this comment.
this is not nice/proper as it builds on a side-effect of a default formatter having a description. it would be better to use the loop above and the if check on line 208
There was a problem hiding this comment.
That does make sense, thanks for the feedback. I added a new commit.
|
|
jrieken
approved these changes
May 11, 2019
|
Thanks. LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71368
This keeps the order of the list and selects the current default formatter.