Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preselect default formatter #73535

Merged
merged 2 commits into from May 11, 2019
Merged

Preselect default formatter #73535

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
326ef1b
Preselect default formatter
vulpivia May 9, 2019
64a4965
Address feedback
vulpivia May 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/vs/workbench/contrib/format/browser/formatActionsMultiple.ts
View file
Open in desktop
Expand Up @@ -209,11 +209,14 @@ async function showFormatterPick(accessor: ServicesAccessor, model: ITextModel,
};
});

// auto focus the default formatter
let autoFocusItem = picks.filter((pick) => pick.description)[0];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not nice/proper as it builds on a side-effect of a default formatter having a description. it would be better to use the loop above and the if check on line 208

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That does make sense, thanks for the feedback. I added a new commit.


const configurePick: IQuickPickItem = {
label: nls.localize('config', "Configure Default Formatter...")
};

const pick = await quickPickService.pick([...picks, { type: 'separator' }, configurePick], { placeHolder: nls.localize('format.placeHolder', "Select a formatter") });
const pick = await quickPickService.pick([...picks, { type: 'separator' }, configurePick], { placeHolder: nls.localize('format.placeHolder', "Select a formatter"), activeItem: autoFocusItem });
if (!pick) {
// dismissed
return undefined;
Expand Down