Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix commandless tasks #76689

Merged
merged 2 commits into from Jul 5, 2019
Merged

Fix commandless tasks #76689

merged 2 commits into from Jul 5, 2019

Conversation

alexr00
Copy link
Member

@alexr00 alexr00 commented Jul 5, 2019

Tasks without a command have always been permitted. They are most commonly used to create composite tasks that only run other tasks. Recently though, all tasks have been given a command so that they could have a presentation. However, this means that they should be check for an actual command name.

Part of #76611

@alexr00 alexr00 added this to the June 2019 Recovery milestone Jul 5, 2019
@alexr00 alexr00 self-assigned this Jul 5, 2019
Copy link
Member

@dbaeumer dbaeumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexr00 alexr00 merged commit 5488957 into release/1.36 Jul 5, 2019
@alexr00 alexr00 deleted the alexr00/fixCommandlessTasks branch July 5, 2019 14:10
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants