Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix commandless tasks #76689

Merged
merged 2 commits into from Jul 5, 2019

Conversation

Projects
None yet
2 participants
@alexr00
Copy link
Member

commented Jul 5, 2019

Tasks without a command have always been permitted. They are most commonly used to create composite tasks that only run other tasks. Recently though, all tasks have been given a command so that they could have a presentation. However, this means that they should be check for an actual command name.

Part of #76611

@alexr00 alexr00 added this to the June 2019 Recovery milestone Jul 5, 2019

@alexr00 alexr00 self-assigned this Jul 5, 2019

@dbaeumer
Copy link
Member

left a comment

LGTM

@alexr00 alexr00 merged commit 5488957 into release/1.36 Jul 5, 2019

6 checks passed

VS Code Build #20190705.55 succeeded
Details
VS Code (Linux) Linux succeeded
Details
VS Code (Windows) Windows succeeded
Details
VS Code (macOS) macOS succeeded
Details
VS Code Distro Sync & Merge Check #20190705.38 succeeded
Details
license/cla All CLA requirements met.

@alexr00 alexr00 deleted the alexr00/fixCommandlessTasks branch Jul 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.