Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP in HTML style tags #80657

Merged
merged 2 commits into from Sep 15, 2019

Conversation

@KapitanOczywisty
Copy link
Contributor

commented Sep 10, 2019

Change will fix behavior from this comment: #33519 (comment)

This problem does not appear in atom because of different html grammar and imo change will be better suited here rather than upstream.

There is pr on atom/language-php atom/language-php#350 however in atom this don't have any effect, because source.css does not exist and problem itself is not present.

Edit:
Of course grammar have to be updated after merge.

@roblourens roblourens added this to the September 2019 milestone Sep 15, 2019
Copy link
Member

left a comment

Wow, this is much simpler than I'd thought. Thanks!

@roblourens roblourens merged commit ea10827 into microsoft:master Sep 15, 2019
@msftclas

This comment has been minimized.

Copy link

commented Sep 15, 2019

CLA assistant check
All CLA requirements met.

@KapitanOczywisty

This comment has been minimized.

Copy link
Contributor Author

commented Sep 15, 2019

This is @esemlabel job, so thanks to him :)

roblourens added a commit that referenced this pull request Sep 15, 2019
This reverts commit ea10827, reversing
changes made to 9f2d08e.
@roblourens

This comment has been minimized.

Copy link
Member

commented Sep 15, 2019

Please make sure you sign the CLA, I had to revert the change.

@KapitanOczywisty

This comment has been minimized.

Copy link
Contributor Author

commented Sep 15, 2019

@roblourens signed

@roblourens

This comment has been minimized.

Copy link
Member

commented Sep 15, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.