Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt icon font in lightbulb actions #81191

Merged
merged 1 commit into from
Sep 19, 2019
Merged

Conversation

miguelsolorio
Copy link
Contributor

Related #78889

This adopts the icon font in editor and panel area for lightbulb actions:

image

image

And I also introduced two new color tokens for these, editor.lightbulbIcon.foreground and editor.lightbulbAutoFixIcon.foreground. When configured will look something like this:

image

image

cc @bpasero @aeschli

@miguelsolorio miguelsolorio merged commit b27dca7 into master Sep 19, 2019
@miguelsolorio miguelsolorio deleted the misolori/icon-font-lighbulb branch September 19, 2019 20:59
@aeschli
Copy link
Contributor

aeschli commented Sep 20, 2019

@misolori Sorry for being late. I'd like to change the color id's to match the color naming style (2 segments: component.property)

editorLightBulb.foreground
editorLightBulb.autoFixForeground

Let me know if it's ok for you if I make the rename.

@miguelsolorio
Copy link
Contributor Author

@aeschli don’t we need to imply it’s for the icon? The other color names include “icon”.

@aeschli
Copy link
Contributor

aeschli commented Sep 20, 2019

As all there is an icon, why not just shorten it to 'LightBulp'?

@miguelsolorio
Copy link
Contributor Author

I was leaning towards consistency across the other icon colors, but I’m ok shortening it to ‘LightBulb’. Feel free to make the change.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants