Status bar wrapping: Wrap only right items. Hide left items on overflow #84465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bpasero
approved these changes
Nov 11, 2019
There was a problem hiding this comment.
@sandy081 I think this is a good direction, however I am missing the visual indicator "..." so that users understand the label is cut off.
Also please check how this behaves when extensions reference icons ($(....)), e.g. would that cause the icon to be broken?
|
Sorry, I did mean to "request more changes", not to approve. |
|
I do not think it is possible to show ellipsis with the flex layout and items with octicon text. Let me know if there is a way. |
|
@sandy081 true. then I suggest we go with this change for insiders and see if people complain |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #84258