Fix undo/redo broken in non-editor webviews #89961
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #89960
Undo/redo is broken in webviews due to the context key being overly aggressive in setting itself as
webviewHasOwnEditFunctions
. I think instead of true, this should set it to be based on if it has a custom editor. This fixeswebviewCommands.ts
, which uses this context key for undo/redo.Repro:
<input>
(e.g. modify the cat coding sample)