Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undo/redo broken in non-editor webviews #89961

Merged
merged 1 commit into from Feb 3, 2020

Conversation

@evangrayk
Copy link
Contributor

evangrayk commented Feb 3, 2020

This PR fixes #89960

Undo/redo is broken in webviews due to the context key being overly aggressive in setting itself as webviewHasOwnEditFunctions. I think instead of true, this should set it to be based on if it has a custom editor. This fixes webviewCommands.ts, which uses this context key for undo/redo.

Repro:

  1. open a webview with an <input> (e.g. modify the cat coding sample)
  2. type into the input
  3. undo & redo with cmd-z and cmd-shift-z work as expected
@mjbvz mjbvz added this to the February 2020 milestone Feb 3, 2020
@mjbvz mjbvz merged commit 0556732 into microsoft:master Feb 3, 2020
5 checks passed
5 checks passed
linux
Details
windows
Details
darwin
Details
VS Code #20200203.94 succeeded
Details
license/cla All CLA requirements met.
@mjbvz

This comment has been minimized.

Copy link
Contributor

mjbvz commented Feb 3, 2020

Thanks!

@evangrayk evangrayk deleted the facebookexperimental:fix-webview-undo branch Feb 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.