Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smartSelect fix #90736

Merged
merged 3 commits into from Feb 17, 2020
Merged

smartSelect fix #90736

merged 3 commits into from Feb 17, 2020

Conversation

@vhpgomes
Copy link
Contributor

vhpgomes commented Feb 15, 2020

This PR fixes #90589

The fix was trivial enough. Included some new unit tests.

Had to change the assertRanges function because of the pipe char. With the pipe, the new tests, which try to reproduce the exact scenario in the issue, were passing.

PS - this is my first PR for a OSS, ever... please forgive me for any mistake or misconduct.

@msftclas

This comment has been minimized.

Copy link

msftclas commented Feb 15, 2020

CLA assistant check
All CLA requirements met.

jrieken added 2 commits Feb 17, 2020
@jrieken jrieken merged commit 6c723d5 into microsoft:master Feb 17, 2020
4 of 5 checks passed
4 of 5 checks passed
linux
Details
windows
Details
darwin
Details
VS Code #20200217.43 failed
Details
license/cla All CLA requirements met.
Details
@jrieken

This comment has been minimized.

Copy link
Member

jrieken commented Feb 17, 2020

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.