bugfix - typescript code completion doesn't recognize property modifiers when more than one exists #94165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes microsoft/TypeScript#37117 (this issue also contains an example of the bug)
This is a simple fix to a simple problem. According to the typescript language service API, the property
kindModifiers
is comma-separated. Here is the relevant interface:https://github.com/microsoft/TypeScript/blob/9c4cbd64fb020970f47b4b068f4007810e388a81/src/services/types.ts#L1051-L1054
the problem occurs when more than one modifier exists, and then no modifier is recognized.