Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore netcoreapp1.0 support for testhost #2554

merged 1 commit into from Sep 16, 2020


Copy link

@sharwell sharwell commented Sep 1, 2020

This pull request updates the build to include netcoreapp1.0 outputs for testhost.exe and testhost.x86.exe. It does not (yet) update tests to cover these cases, or NuGet packaging to include the output binaries.

@sharwell sharwell marked this pull request as ready for review Sep 8, 2020
@Haplois Haplois self-requested a review Sep 9, 2020
@Haplois Haplois marked this pull request as draft Sep 9, 2020
Copy link

Haplois commented Sep 9, 2020

All looks OK, but I am converting this to draft, I'll add new targets to NuGet packages and tests and then merge.

@Haplois Haplois marked this pull request as ready for review Sep 15, 2020
Copy link

msftbot bot commented Sep 15, 2020

Hello @Haplois!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@msftbot msftbot bot merged commit 50e6af6 into microsoft:master Sep 16, 2020
2 checks passed
Copy link

ViktorHofer commented Sep 25, 2020

@sharwell what's the reason for adding/restoring netcoreapp1.0 support? Wondering as netcoreapp1.0 has been EOL for a long time.

@sharwell sharwell deleted the fix-netstandard1 branch Sep 25, 2020
Copy link
Member Author

sharwell commented Sep 25, 2020

@ViktorHofer It allows multi-targeting projects to move forward with adding support for the latest runtime targets without blocking adoption of new targets on the removal of an unrelated one. The issue I hit directly involved analyzer testing for Roslyn analyzers that support Visual Studio 2015, which is still supported. We could carve out slightly different cases over time, where the .NET Framework tools from 2015 keep working but the .NET Core tooling just breaks at some point, but that seemed unnecessary considering the ease with which .NET Core 1.x can be supported by the test runner.

mburumaxwell pushed a commit to tinglesoftware/falu-dotnet that referenced this pull request Jun 12, 2021
Bumps [Microsoft.NET.Test.Sdk]( from 16.8.3 to 16.9.1.

#Release notes

*Sourced from [Microsoft.NET.Test.Sdk's releases](*

> ## v16.9.1
> See the release notes [here](
> ## v16.9.0-preview-20210127-04
> See the release notes [here](
> ## v16.9.0-preview-20210106-01
> See the release notes [here](
> ## v16.9.0-preview-20201123-03
> See the release notes [here](
> -------------------------------
> ## v16.9.0-preview-20201020-06
> See the release notes [here](
> -------------------------------
> ## 16.9.0-preview-20201020-06
> ### Issue Fixed
> * Enable Fakes Datacollector settings to be added in design mode [#2586](microsoft/vstest#2586)
> * Fix blame parameter, warning, and add all testhosts to be ngend [#2579](microsoft/vstest#2579)
> * Add netcoreapp1.0 support to `Microsoft.TestPlatform.TestHost` NuGet [#2569](microsoft/vstest#2569)
> * Use bitness from process or OS [#2571](microsoft/vstest#2571)
> * Restore netcoreapp1.0 support for testhost [#2554](microsoft/vstest#2554)
> * Get symbols of DiaSymReader from externals [#2560](microsoft/vstest#2560)
> * Do not force .NET4.5 in case legacy test settings are provided [#2545](microsoft/vstest#2545)
> * Simplify package references [#2559](microsoft/vstest#2559)
> * Enable default compile items for Microsoft.TestPlatform.PlatformAbstractions [#2556](microsoft/vstest#2556)
> * Avoid logging >Task returned false but did not log an error.< [#2557](microsoft/vstest#2557)
> * Fixed code coverage compatibility issue [#2527](microsoft/vstest#2527)
> * Add environment variables to enable MacOS dump
> * Adding test run attachments processing [#2463](microsoft/vstest#2463)
> See full log [here](microsoft/vstest@v16.8.0-release-20200921-02...v16.9.0-preview-20201020-06)
> ### Drops
> * TestPlatform vsix: [16.9.0-preview-20201020-06](;/TestPlatform.vsix)
> * Microsoft.TestPlatform.ObjectModel : [16.9.0-preview-20201020-06](

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants