Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed assembly loading issue for netcoreapp. #2631

Merged
merged 1 commit into from
Nov 13, 2020

Conversation

Haplois
Copy link
Contributor

@Haplois Haplois commented Nov 13, 2020

Copy link
Member

@nohwnd nohwnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please share why is this needed, because I don't get it from the linked issue without investigating it. And what impact it has on package sizes.

scripts/build.ps1 Outdated Show resolved Hide resolved
src/package/nuspec/TestPlatform.TestHost.nuspec Outdated Show resolved Hide resolved
src/package/nuspec/TestPlatform.TestHost.nuspec Outdated Show resolved Hide resolved
@Haplois Haplois force-pushed the testhost-fix branch 3 times, most recently from 1f82e26 to 6edb278 Compare November 13, 2020 07:40
@Haplois
Copy link
Contributor Author

Haplois commented Nov 13, 2020

Please share why is this needed, because I don't get it from the linked issue without investigating it. And what impact it has on package sizes.

TestHost depends on PlatformAbstractions, it's is provided by ObjectModel which is built against netstandard2.0. TestHost fails to load, so I added one built against the same library. That fixed the problem.

@Haplois Haplois merged commit bb360cb into microsoft:master Nov 13, 2020
@Haplois Haplois deleted the testhost-fix branch November 13, 2020 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants