Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPP runner under .NET (Core) #3003

Merged
merged 21 commits into from
Oct 11, 2021

Conversation

nohwnd
Copy link
Member

@nohwnd nohwnd commented Aug 5, 2021

Description

Please add a meaningful description for this change.
Ensure the PR has required unit tests.

Related issue

Kindly link any related issues. E.g. Fixes #xyz.

Resolve testhost also from vstest.console folder when we cannot find it based on runtime config, or next to the test dll. This allows .net core projects that don't depend on test.sdk to run, as well as non-executable projects, and possibly native dlls - CPP runner
Copy link
Contributor

@Haplois Haplois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Under temp/testhost-core folder there are binaries, was that intentional?

@nohwnd nohwnd changed the title Prototype for using no Test.Sdk CPP runner under .NET (Core) Sep 13, 2021
@nohwnd
Copy link
Member Author

nohwnd commented Sep 13, 2021

yes it was intentional. Now I replaced them with a set of dlls that will come from nuget as soon as we get one. There are also few runtimeconfig files in temp/testhost now that I am not sure where to put in the final package.

@nohwnd nohwnd marked this pull request as ready for review October 8, 2021 11:32
@nohwnd nohwnd requested a review from Haplois October 8, 2021 11:33
nohwnd and others added 3 commits October 8, 2021 15:29
…HostManager.cs

Co-authored-by: Marco Rossignoli <marco.rossignoli@gmail.com>
…HostManager.cs

Co-authored-by: Marco Rossignoli <marco.rossignoli@gmail.com>
@nohwnd nohwnd enabled auto-merge (squash) October 11, 2021 12:09
@nohwnd nohwnd merged commit 4483afc into microsoft:main Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants