Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update feature flag logic to disable only semantics #3479

Merged
merged 7 commits into from
Mar 17, 2022
Merged

Update feature flag logic to disable only semantics #3479

merged 7 commits into from
Mar 17, 2022

Conversation

MarcoRossignoli
Copy link
Contributor

@MarcoRossignoli MarcoRossignoli commented Mar 17, 2022 •
edited
Loading

Update feature flag logic to disable only semantics

const embedding sample
image

@MarcoRossignoli MarcoRossignoli enabled auto-merge (squash) March 17, 2022 13:00
MarcoRossignoli and others added 4 commits March 17, 2022 14:20
@nohwnd
Copy link
Member

nohwnd commented Mar 17, 2022

My point for changing DisableFeatureFlag to FeatureFlag was that I will never remember how to look it up in intellisense otherwise.

@MarcoRossignoli
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MarcoRossignoli MarcoRossignoli merged commit 080b60d into microsoft:main Mar 17, 2022
@MarcoRossignoli MarcoRossignoli deleted the fixflaglogic branch March 17, 2022 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evangelink Evangelink Evangelink left review comments

@nohwnd nohwnd nohwnd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarcoRossignoli @nohwnd @Evangelink