Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint PR template and add new change types. #3

Merged
merged 1 commit into from
Jun 10, 2021
Merged

Lint PR template and add new change types. #3

merged 1 commit into from
Jun 10, 2021

Conversation

abeltrano
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Breaking change
  • Documentation
  • Infrastructure

Goals

Ensure documentation and infrastructure PRs can be categorized as such.

Technical Details

  • Add 'Documentation' and 'Infrastructure' as available change types.
  • Fix miscellaneous markdown lint issues.

Test Results

  • N/A

Reviewer Focus

  • None

Future Work

  • None

Checklist

  • Build target all compiles cleanly.
  • cppcheck produces no output.
  • clang-format delta produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team June 10, 2021 02:42
@abeltrano abeltrano merged commit 9d253b3 into main Jun 10, 2021
@abeltrano abeltrano deleted the abeltrano/prtemplatetypes branch June 11, 2021 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craiz craiz craiz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abeltrano @craiz