Starting a demoscripts folder, moved WSL into own helper script #70
Conversation
scripts/VirtualizationTools.ps1
Outdated
| choco install -y Microsoft-Hyper-V-All -source windowsFeatures | ||
| # alternative to above: Enable-WindowsOptionalFeature -Online -NoRestart -FeatureName Microsoft-Windows-Subsystem-Linux | ||
| # alternative to above: Enable-WindowsOptionalFeature -Online -NoRestart -FeatureName Microsoft-Hyper-V | ||
| choco install -y docker-for-windows |
There was a problem hiding this comment.
I would have one for docker, not virtualization.
There was a problem hiding this comment.
my statement is it feels overreaching from the title. I could see someone misunderstanding this.
Also what if someone is on not a SKU of windows that doesn't support Hyper-V (aka home edition), what happens?
There was a problem hiding this comment.
separate docker makes sense. and then name this one Hyper-V
There was a problem hiding this comment.
When a helper script is down to 1-line we should consider getting rid of it
There was a problem hiding this comment.
I'll make some changes to this PR and we may need to revisit again later
devops_azure.ps1
Outdated
|
|
||
|
|
||
| #--- Browsers --- | ||
| choco install -y googlechrome |
There was a problem hiding this comment.
maybe have this be "Browsers.ps1"
There was a problem hiding this comment.
this would include FireFox as well.
There was a problem hiding this comment.
hmm.... yeah... that's not a bad idea
There was a problem hiding this comment.
I think the web tooling one has this as well. I think we have a bug for that
No description provided.