Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import and build macros should emit a warning or error for missing namespace/type #210

Closed
Eroc33 opened this issue Jun 8, 2020 · 1 comment · Fixed by #220
Closed

Import and build macros should emit a warning or error for missing namespace/type #210

Eroc33 opened this issue Jun 8, 2020 · 1 comment · Fixed by #220
Labels
enhancement New feature or request

Comments

@Eroc33
Copy link

Eroc33 commented Jun 8, 2020 •
edited
Loading

Expected behaviour:

If I import a nonexistent namespace with not_a_real_namespace::* syntax, or a nonexistent type with namespace::{NotARealType} syntax I should recieve some sort of warning or error.

Current behaviour:

Compilation silently continues
Edit:
Compilation silently continues for missing types, but panics for namespaces (this is probably better than being silent)
@kennykerr kennykerr added the enhancement New feature or request label Jun 8, 2020
@kennykerr kennykerr linked a pull request Jun 10, 2020 that will close this issue
Better error message on missing namespace #220
Merged
@rylev rylev reopened this Jun 10, 2020
@kennykerr kennykerr added this to the 0.8 milestone Jun 16, 2020
@kennykerr
Copy link
Collaborator

This should be fixed as of #773 - let me know if you notice any further issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Better error message on missing namespace microsoft/windows-rs
3 participants
@Eroc33 @rylev @kennykerr