-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version information to RC file and display in About dialog box #89
Conversation
src/wfdlgs3.c
Outdated
if (GetFileVersionInfo(wszCurrentModulePath, 0, cbVerInfo, pFileVerInfo)) | ||
{ | ||
// Get the pointer to the VS_FIXEDFILEINFO structure | ||
if (VerQueryValue(pFileVerInfo, L"\\", (LPVOID *)&pFixedFileInfo, &uLen)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you are using VerQueryValue (not VerQueryValueW), is there a reason why you use L"\\"
, rather than TEXT("\\")
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I was assuming UNICODE would be set at build time, but I agree that using TEXT would be more consistent. I'll make that change and also use TCHAR rather than WCHAR.
Hi @matthewjustice , can you update this PR now that I have reverted b51bf08? Thanks. |
Looks fine. A squash and merge gives the right result. |
Your change, squashed, is checked in. I hope I didn't screw up again. |
Thanks @craigwi! The commit looks good to me. |
So are we going to use gitversion to have the version number automatically updated with commits? It sounds the most practical. |
This change does the following:
Notes: