Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify product name rather than rely on ntverp default #67

Closed
wants to merge 2 commits into from

Conversation

matthewjustice
Copy link
Contributor

Issue #53 calls out that the Winfile.exe product name is "Windows (R) Win7 DDK driver". This is because res.rc includes ntverp.h, and the version of ntverp.ver that is included with Windows 10 SDK defines the following:

#define VER_PRODUCTNAME_STR "Windows (R) Win 7 DDK driver"

I addressed this by defining the product name as "File Manager", although another product name would be fine if something else is preferred. I also undefined VER_PRODUCTNAME_STR first to avoid resource compiler warning RC4005.

@craigwi
Copy link
Contributor

craigwi commented Apr 12, 2018

I would like to combine the AboutDlg changes with this change and do proper build versions.

I am also looking at AppVeyor for build/deploy via Chocolatey.

Anyone have experience with https://github.com/GitTools/GitVersion or recommend something else?

@matthewjustice
Copy link
Contributor Author

matthewjustice commented Apr 12, 2018

I'm working on a change right now that removes the ntverp.h dependency (since it is primarily intended for internal NT builds), and defines the full version, etc in the resource file, and then displays the version info in the AboutDlg. As it stands right now, the version number is fully coming from ntverp.h, which we don't want.

So, I could go ahead and make this change as first step (break the ntverp.h dependency, define version info in the rc file, and display the version in About), and then we could look into ways to automate updating the version number as part of the build process.

@matthewjustice
Copy link
Contributor Author

PR #89, if accepted, will supersede this PR.

@craigwi
Copy link
Contributor

craigwi commented Apr 12, 2018

I think PR #89 a great change. I will merge it after I undo the last commit.

@craigwi craigwi closed this Apr 12, 2018
@matthewjustice matthewjustice deleted the product-name branch April 12, 2018 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants