Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Firewall Rules #1782

Open
mottech20 opened this issue Dec 7, 2021 · 0 comments
Open

Create Firewall Rules #1782

mottech20 opened this issue Dec 7, 2021 · 0 comments
Labels
Issue-Feature This is a feature request for the Windows Package Manager client.

Comments

@mottech20
Copy link

Description of the new feature / enhancement

Currently I have an 'App Installer' predefined rule in my Windows Defender Firewall with Advanced Security. The rule allows outbound traffic for the "Microsoft.DesktopAppInstaller_*" app package. However, this rule doesn't seem to cover all executables in the package and winget can still send outbound traffic even if this rule is blocked.

But on the opposite end, if all outbound traffic is blocked in the firewall, winget will not be able to send/receive data even if this rule is enabled. Another rule needs to be defined to give AppInstallerCLI.exe permission for outbound traffic.

Since the path of the AppInstallerCLI.exe changes with every update, it gets quiet bothersome to update the firewall rule every time.

Proposed technical implementation details

  • Include AppInstallerCLI.exe in the predefined firewall rule for App Installer.
  • Update the corresponding firewall rule with each version update.
@mottech20 mottech20 added the Issue-Feature This is a feature request for the Windows Package Manager client. label Dec 7, 2021
@ghost ghost added the Needs-Triage Issue need to be triaged label Dec 7, 2021
@denelon denelon removed the Needs-Triage Issue need to be triaged label Dec 8, 2021
Trenly added a commit to Trenly/winget-cli that referenced this issue Mar 22, 2024
411a10915 mint 2.10.19
096a9a1bb Merge pull request microsoft#1782 from microsoft/fix_uri_parsing
006271f6a make Uri.is_host_loopback() only return true for localhost and 127.0.0.1 exactly
9c654889e Remove email list from the readme
31e7feacc Merge pull request microsoft#1718 from dashanji/Fix-typo
e1b6a8e61 Merge pull request microsoft#1711 from Fighter19/pr-fix-safeint3
c5dcbb5bb Merge pull request microsoft#1717 from microsoft/users/GitHubPolicyService/f2ee14d6-8d6b-4313-b754-3880e015f7c3
98ee36dac Fix typo
a57f45918 Microsoft mandatory file
3308d9728 Fix likely typo in SafeInt3.hpp, that results in error with clang 15
07cf58910 Merge pull request microsoft#1429 from NN---/fix/value_int_ctor
3eac925ad Update Release/include/cpprest/json.h
06363bc78 Update Release/include/cpprest/json.h
bfe348779 Merge pull request #1577 from JvdGlind/hidden_visibility_support_macos
0ddc61829 Clarify cpprestsdk level of support
804448058 export http_exception for non Windows builds
d9d7f5ed4 Merge pull request microsoft#1496 from icherniukh/oauth2_client_credentials
8ae5da616 Update oauth2.h
708a5df2b Add support for oauth2 using only client credentials
5408f1dc9 Add constructor from all integer types.

git-subtree-dir: src/cpprestsdk/cpprestsdk
git-subtree-split: 411a109150b270f23c8c97fa4ec9a0a4a98cdecf
Trenly added a commit to Trenly/winget-cli that referenced this issue Mar 22, 2024
411a10915 mint 2.10.19
096a9a1bb Merge pull request microsoft#1782 from microsoft/fix_uri_parsing
006271f6a make Uri.is_host_loopback() only return true for localhost and 127.0.0.1 exactly
9c654889e Remove email list from the readme
31e7feacc Merge pull request microsoft#1718 from dashanji/Fix-typo
e1b6a8e61 Merge pull request microsoft#1711 from Fighter19/pr-fix-safeint3
c5dcbb5bb Merge pull request microsoft#1717 from microsoft/users/GitHubPolicyService/f2ee14d6-8d6b-4313-b754-3880e015f7c3
98ee36dac Fix typo
a57f45918 Microsoft mandatory file
3308d9728 Fix likely typo in SafeInt3.hpp, that results in error with clang 15
07cf58910 Merge pull request microsoft#1429 from NN---/fix/value_int_ctor
3eac925ad Update Release/include/cpprest/json.h
06363bc78 Update Release/include/cpprest/json.h
bfe348779 Merge pull request #1577 from JvdGlind/hidden_visibility_support_macos
0ddc61829 Clarify cpprestsdk level of support
804448058 export http_exception for non Windows builds
d9d7f5ed4 Merge pull request microsoft#1496 from icherniukh/oauth2_client_credentials
8ae5da616 Update oauth2.h
708a5df2b Add support for oauth2 using only client credentials
5408f1dc9 Add constructor from all integer types.

git-subtree-dir: src/cpprestsdk/cpprestsdk
git-subtree-split: 411a109150b270f23c8c97fa4ec9a0a4a98cdecf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature This is a feature request for the Windows Package Manager client.
Projects
None yet
Development

No branches or pull requests

2 participants