Switch to hardlink for retry if rename does not succeed #1496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge microsoft/winget-cli changes.
Rest endpoint helper and json object field check - Bug fix (microsoft#821)
Merge latest winget changes.
… microsoft-master
yao-msft
reviewed
Sep 22, 2021
| @@ -256,8 +256,9 @@ namespace AppInstaller::CLI::Workflow | |||
| if (retry) | |||
| { | |||
| std::this_thread::sleep_for(250ms); | |||
| // If it fails again, let that one throw | |||
| std::filesystem::rename(installerPath, renamedDownloadedInstaller); | |||
| // If retry fails, try copying with hardlink. The file at installerPath will not be cleaned up after installation, | |||
|
Please don't merge for me. Still trying to do some more testing. |
JohnMcPMS
reviewed
Sep 22, 2021
| std::filesystem::rename(installerPath, renamedDownloadedInstaller); | ||
| // If retry fails, try copying with hardlink. The file at installerPath will not be cleaned up after installation, | ||
| // but it is in a temp folder. | ||
| std::filesystem::copy(installerPath, renamedDownloadedInstaller, std::filesystem::copy_options::create_hard_links); |
There was a problem hiding this comment.
I was thinking to make it retry every 100ms for 500ms, and only then copy. Since the file won't get cleaned up we would really prefer the rename.
|
Sorry, I drank your milkshake 🥛 |
Trenly
added a commit
to Trenly/winget-cli
that referenced
this pull request
Mar 22, 2024
411a10915 mint 2.10.19 096a9a1bb Merge pull request microsoft#1782 from microsoft/fix_uri_parsing 006271f6a make Uri.is_host_loopback() only return true for localhost and 127.0.0.1 exactly 9c654889e Remove email list from the readme 31e7feacc Merge pull request microsoft#1718 from dashanji/Fix-typo e1b6a8e61 Merge pull request microsoft#1711 from Fighter19/pr-fix-safeint3 c5dcbb5bb Merge pull request microsoft#1717 from microsoft/users/GitHubPolicyService/f2ee14d6-8d6b-4313-b754-3880e015f7c3 98ee36dac Fix typo a57f45918 Microsoft mandatory file 3308d9728 Fix likely typo in SafeInt3.hpp, that results in error with clang 15 07cf58910 Merge pull request microsoft#1429 from NN---/fix/value_int_ctor 3eac925ad Update Release/include/cpprest/json.h 06363bc78 Update Release/include/cpprest/json.h bfe348779 Merge pull request #1577 from JvdGlind/hidden_visibility_support_macos 0ddc61829 Clarify cpprestsdk level of support 804448058 export http_exception for non Windows builds d9d7f5ed4 Merge pull request microsoft#1496 from icherniukh/oauth2_client_credentials 8ae5da616 Update oauth2.h 708a5df2b Add support for oauth2 using only client credentials 5408f1dc9 Add constructor from all integer types. git-subtree-dir: src/cpprestsdk/cpprestsdk git-subtree-split: 411a109150b270f23c8c97fa4ec9a0a4a98cdecf
Trenly
added a commit
to Trenly/winget-cli
that referenced
this pull request
Mar 22, 2024
411a10915 mint 2.10.19 096a9a1bb Merge pull request microsoft#1782 from microsoft/fix_uri_parsing 006271f6a make Uri.is_host_loopback() only return true for localhost and 127.0.0.1 exactly 9c654889e Remove email list from the readme 31e7feacc Merge pull request microsoft#1718 from dashanji/Fix-typo e1b6a8e61 Merge pull request microsoft#1711 from Fighter19/pr-fix-safeint3 c5dcbb5bb Merge pull request microsoft#1717 from microsoft/users/GitHubPolicyService/f2ee14d6-8d6b-4313-b754-3880e015f7c3 98ee36dac Fix typo a57f45918 Microsoft mandatory file 3308d9728 Fix likely typo in SafeInt3.hpp, that results in error with clang 15 07cf58910 Merge pull request microsoft#1429 from NN---/fix/value_int_ctor 3eac925ad Update Release/include/cpprest/json.h 06363bc78 Update Release/include/cpprest/json.h bfe348779 Merge pull request #1577 from JvdGlind/hidden_visibility_support_macos 0ddc61829 Clarify cpprestsdk level of support 804448058 export http_exception for non Windows builds d9d7f5ed4 Merge pull request microsoft#1496 from icherniukh/oauth2_client_credentials 8ae5da616 Update oauth2.h 708a5df2b Add support for oauth2 using only client credentials 5408f1dc9 Add constructor from all integer types. git-subtree-dir: src/cpprestsdk/cpprestsdk git-subtree-split: 411a109150b270f23c8c97fa4ec9a0a4a98cdecf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User reports of rename failing due to unknown issue (thread here: microsoft/PowerToys#13271 ). I had seen this previously and before the repro went away, switching it to a hardlink copy was successful. Using that solution here.
Microsoft Reviewers: Open in CodeFlow