Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exit the locale choice loop if the default localization is good enough #1500

Merged
merged 1 commit into from
Sep 23, 2021
Merged

Exit the locale choice loop if the default localization is good enough #1500

merged 1 commit into from
Sep 23, 2021

Conversation

JohnMcPMS
Copy link
Member

@JohnMcPMS JohnMcPMS commented Sep 23, 2021 •
edited by ghost
Loading

Change

If the default localization is good enough, then exit the locale choice loop even if we do not find a better localization choice.

Microsoft Reviewers: Open in CodeFlow

@JohnMcPMS JohnMcPMS requested a review from a team as a code owner September 23, 2021 04:18
yao-msft
yao-msft approved these changes Sep 23, 2021
View reviewed changes
Copy link
Contributor

@yao-msft yao-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@JohnMcPMS JohnMcPMS merged commit 3ffb45c into microsoft:master Sep 23, 2021
@JohnMcPMS JohnMcPMS deleted the locchoice branch September 23, 2021 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yao-msft yao-msft yao-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohnMcPMS @yao-msft