Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation for Portable Uninstall and Upgrade #2140

Merged
merged 26 commits into from
May 14, 2022
Merged

Implementation for Portable Uninstall and Upgrade #2140

merged 26 commits into from
May 14, 2022

Conversation

ryfu-msft
Copy link
Contributor

@ryfu-msft ryfu-msft commented May 5, 2022 •
edited by ghost
Loading

Related to:

This PR adds the implementation for supporting the uninstall and upgrade scenario for the portable installerType:

Changes:

  • Rearranges the write to registry order so that if the upgrade scenario fails, the existing registry values are preserved.
  • Adds the uninstall flow so that the uninstall flow removes the appropriate installed files related to the portable.
  • Adds cleanup functionality to the install flow if install fails.
  • Adds support for --purge and --preserve

Tests:

  • Added unit tests to workflow for update and uninstall
  • Added E2E tests for upgrade with the uninstallPrevious upgrade behavior
  • Added E2E tests for uninstall as well as incorporating uninstall in the cleanup process for install tests
Microsoft Reviewers: Open in CodeFlow

@ryfu-msft ryfu-msft requested a review from a team as a code owner May 5, 2022 22:26
@ryfu-msft ryfu-msft marked this pull request as draft May 5, 2022 23:48
JohnMcPMS
JohnMcPMS requested changes May 10, 2022
View reviewed changes
src/AppInstallerCLICore/Commands/UninstallCommand.cpp Show resolved Hide resolved
src/AppInstallerCLICore/Workflows/InstallFlow.cpp Show resolved Hide resolved
src/AppInstallerCLICore/Workflows/InstallFlow.cpp Show resolved Hide resolved
src/AppInstallerRepositoryCore/Microsoft/ARPHelper.h Outdated Show resolved Hide resolved
src/AppInstallerRepositoryCore/Public/winget/RepositorySearch.h Outdated Show resolved Hide resolved
src/AppInstallerCLICore/Workflows/PortableFlow.cpp Outdated Show resolved Hide resolved
src/AppInstallerCLICore/Workflows/PortableFlow.cpp Outdated Show resolved Hide resolved
src/AppInstallerCLICore/Workflows/UninstallFlow.cpp Outdated Show resolved Hide resolved
src/AppInstallerCLICore/Workflows/WorkflowBase.cpp Outdated Show resolved Hide resolved
src/AppInstallerCLIPackage/Shared/Strings/en-us/winget.resw Outdated Show resolved Hide resolved
@ghost ghost added the Needs-Author-Feedback Issue needs attention from issue or PR author label May 10, 2022
@ghost ghost removed the Needs-Author-Feedback Issue needs attention from issue or PR author label May 11, 2022
@ryfu-msft ryfu-msft marked this pull request as ready for review May 11, 2022 20:36
@ghost ghost added Needs-Author-Feedback Issue needs attention from issue or PR author and removed Needs-Author-Feedback Issue needs attention from issue or PR author labels May 11, 2022
@ryfu-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ryfu-msft ryfu-msft merged commit 4df817b into microsoft:master May 14, 2022
@ryfu-msft ryfu-msft deleted the uninstallFlow branch May 14, 2022 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trenly Trenly Trenly left review comments

@denelon denelon denelon left review comments

@JohnMcPMS JohnMcPMS JohnMcPMS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ryfu-msft @JohnMcPMS @Trenly @denelon