Make SQLite wrapper more resilient #4196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r fail fast; don't close on commit failure
florelis
previously approved these changes
Feb 23, 2024
Comment on lines
+171
to
172
| m_dbconn = std::make_shared<details::SharedConnection>(); | ||
| m_id = GetNextConnectionId(); |
There was a problem hiding this comment.
Is there any reason to not do these in initializer list?
There was a problem hiding this comment.
No, but there isn't really a big reason to do them in the list either.
ryfu-msft
approved these changes
Feb 26, 2024
JohnMcPMS
added a commit
to JohnMcPMS/winget-cli
that referenced
this pull request
Feb 27, 2024
We are seeing some errors from the SQLite usage that appear to largely be related to contention and the `FAIL_FAST` behavior for savepoint errors. This change is attempting to address the issue by making contention less impactful and moving away from `FAIL_FAST`. ## Change - Adds a busy timeout to SQLite connections by default and provides a method to change the value if callers desire. This should prevent small contentions from causing errors. - Moves from using `FAIL_FAST` on critical errors to simply "closing" the connection, making it non-functional for standard use. - No longer requests this failure behavior for savepoint commit errors; the rollback can handle that if needed.
ryfu-msft
pushed a commit
that referenced
this pull request
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are seeing some errors from the SQLite usage that appear to largely be related to contention and the
FAIL_FASTbehavior for savepoint errors. This change is attempting to address the issue by making contention less impactful and moving away fromFAIL_FAST.Change
FAIL_FASTon critical errors to simply "closing" the connection, making it non-functional for standard use.Validation
Added tests for the busy timeout and connection closing.
Microsoft Reviewers: Open in CodeFlow