Fix test error and change pipeline to properly report test crash #4204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryfu-msft
approved these changes
Feb 26, 2024
yao-msft
approved these changes
Feb 26, 2024
JohnMcPMS
added a commit
to JohnMcPMS/winget-cli
that referenced
this pull request
Feb 27, 2024
…rosoft#4204) ## Change Fixes a test error that would crash the process due an exception from a destructor (in test code). Changes the tasks that run these tests to use `condition: succeededOrFailed()` rather than `continueOnError: true`, as the latter results in a warning rather than the formers error. ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/microsoft/winget-cli/pull/4204)
ryfu-msft
pushed a commit
that referenced
this pull request
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Fixes a test error that would crash the process due an exception from a destructor (in test code).
Changes the tasks that run these tests to use
condition: succeededOrFailed()rather thancontinueOnError: true, as the latter results in a warning rather than the formers error.Microsoft Reviewers: Open in CodeFlow