Add support for setting source trust level #4216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
JohnMcPMS
reviewed
Mar 21, 2024
There was a problem hiding this comment.
I'm not sure that StoreOrigin should even be exposed. It doesn't really hurt anything directly, but I also don't foresee anyone using it (except us for testing). My expectation is only that it causes confusion. I would suggest that it be supported but undocumented (including in the argument description and error messages).
src/AppInstallerRepositoryCore/Public/winget/RepositorySource.h
Outdated
Show resolved
Hide resolved
yao-msft
reviewed
Mar 22, 2024
src/AppInstallerRepositoryCore/Public/winget/RepositorySource.h
Outdated
Show resolved
Hide resolved
yao-msft
reviewed
Mar 22, 2024
JohnMcPMS
reviewed
Mar 25, 2024
|
|
||
| // Trust level is represented as an array of trust level strings since there can be multiple flags set. | ||
| int i = 0; | ||
| for (std::string entry : TrustLevel) |
There was a problem hiding this comment.
nit: There is a for loop syntax that is designed just for this...
JohnMcPMS
previously approved these changes
Mar 25, 2024
JohnMcPMS
reviewed
Mar 26, 2024
| @@ -357,7 +357,8 @@ namespace AppInstaller::Settings | |||
| json["Explicit"] = Explicit; | |||
|
|
|||
| // Trust level is represented as an array of trust level strings since there can be multiple flags set. | |||
| for (int i = 0; i < TrustLevel.size(); ++i) | |||
| int trustLevelLength = static_cast<int>(TrustLevel.size()); | |||
| for (int i = 0; i < trustLevelLength; ++i) | |||
There was a problem hiding this comment.
nit: The better solution is generally to use size_t i.
JohnMcPMS
approved these changes
Mar 26, 2024
|
Is this the fix for #4046 (installations from REST sources hanging indefinitely due to MotW)? |
|
@jantari, yes, this work will accrue to unblocking the hang. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR adds support for specifying the trust level and making a source explicit when adding a new source. If a source is
explicit, the source will not be discoverable unless explictly declared when searching for a package. i.e.winget search foo.bar --source explicitSource--trust-level 'trusted|storeOriginwinget source listwill also show their current state. The only way to remove the trust level or explicit state is by removing the source entirely.Added unit and E2E tests to verify these behaviors.
Microsoft Reviewers: Open in CodeFlow