Better server start coordination #4292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yao-msft
previously approved these changes
Mar 21, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This comment has been minimized.
This comment has been minimized.
yao-msft
approved these changes
Mar 22, 2024
ryfu-msft
pushed a commit
to ryfu-msft/winget-cli
that referenced
this pull request
Mar 25, 2024
## Change Improve this named event creation by having both sides try to create or open it. The current version will almost always have to sleep at least once while the server sets up and can completely fail if it takes too long. With this change, we should be able to properly wait for startup on the first attempt.
ryfu-msft
added a commit
that referenced
this pull request
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Improve this named event creation by having both sides try to create or open it. The current version will almost always have to sleep at least once while the server sets up and can completely fail if it takes too long. With this change, we should be able to properly wait for startup on the first attempt.
Validation
Manual verification of functionality with a sleep introduced to ensure failure of previous code.
Microsoft Reviewers: Open in CodeFlow