Block elevated process from overriding hash mismatch #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e number of strings loc'd along the way
yao-msft
reviewed
Jul 8, 2020
| Argument::ForType(Args::Type::Log), | ||
| Argument::ForType(Args::Type::Override), | ||
| Argument::ForType(Args::Type::InstallLocation), | ||
| Argument{ "force", Argument::NoAlias, Args::Type::Force, Resource::String::InstallForceArgumentDescription, ArgumentType::Flag }, |
There was a problem hiding this comment.
Argument [](start = 12, length = 8)
Curious why is this one not added to ForType?
There was a problem hiding this comment.
It uses different help text for each case. Honestly, now that we have the resource strings that whole function could be done away with.
In reply to: 451283891 [](ancestors = 451283891)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
To prevent the user from running a package whose hash does not match in an elevated context, this change explicitly blocks the scenario. In addition, the inline prompt to proceed when the hash does not match is replaced with usage of the --force option.
While executing on this change, I also took on a fair amount of additional localization work that has yet to be completed. This included transitioning many existing strings to resources, and removal of the prompt functionality altogether. This is partly due to localizing it being a headache, and partly because it prevents easy scripting.
Validation
Existing regression tests.
Microsoft Reviewers: Open in CodeFlow