Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MusicBrainz.Picard version 2.11.0 #136674

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Fix MusicBrainz.Picard version 2.11.0 #136674

merged 1 commit into from
Jan 26, 2024

Conversation

Trenly
Copy link
Contributor

@Trenly Trenly commented Jan 26, 2024 •
edited by microsoft-github-policy-service bot

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jan 26, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit f1fede4 into microsoft:master Jan 26, 2024
8 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jan 26, 2024
@phw
Copy link
Contributor

phw commented Jan 26, 2024

Thanks for this fix. I need to take closer attention to the results of "wingetcreate update" it seems.

I had noticed it had moved the "AppsAndFeaturesEntries" section up one level, but thought this might be intentional if there is only one installer.

Is this something that should be reported for winget-create?

@Trenly
Copy link
Contributor Author

Trenly commented Jan 26, 2024

Thanks for this fix. I need to take closer attention to the results of "wingetcreate update" it seems.

I had noticed it had moved the "AppsAndFeaturesEntries" section up one level, but thought this might be intentional if there is only one installer.

Is this something that should be reported for winget-create?

Moving it up one level shouldn’t be an issue; In fact, I missed that it was there. The primary issue is that DisplayVersion was missing

@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@Trenly Trenly deleted the Arp branch January 26, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephengillie stephengillie stephengillie approved these changes

Assignees
No one assigned
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Package Issue]: MusicBrainz.Picard
4 participants
@Trenly @wingetbot @phw @stephengillie