Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: PolarGoose.ShowWhatProcessLocksFile version 6.0 #153131

Conversation

PolarGoose
Copy link
Contributor

@PolarGoose PolarGoose commented May 11, 2024

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Manifest-Metadata-Consistency New-Manifest Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels May 11, 2024
@wingetbot
Copy link
Collaborator

=== manifests\p\PolarGoose\ShowWhatProcessLocksFile\6.0 ===
Missing Properties value based on version 3.0:
PublisherUrl
PublisherSupportUrl
Author
PackageUrl
LicenseUrl
ReleaseNotesUrl
InstallerType
UpgradeBehavior
ReleaseDate

@stephengillie
Copy link
Collaborator

Hi @PolarGoose,

This manifest removes Apps and Features entries that are present in previous PR versions. These entries should be added to this version, to maintain version matching, and prevent the 'upgrade always available' situation with this package.

(Automated response - build 880.)

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label May 13, 2024
@PolarGoose
Copy link
Contributor Author

@stephengillie,
Thank you for the remark.
I have tested my manifest, and it creates an Apps and Features entry:
image

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels May 13, 2024
@stephengillie
Copy link
Collaborator

Oh - this is referring to the AppsAndFeaturesEntries field and values in a manifest. Not the entry in the Settings page. This message is out of date. The main value that it's seeking to mitigate is DisplayVersion, but that's not in use here, so it's not as important.

The previous PR had:

  AppsAndFeaturesEntries:
    - ProductCode: '{2D35E2E6-3FE3-4D1E-9B94-8352495D1A35}'
      UpgradeCode: '{ECBB21BF-5B26-4971-AAC2-D3528A7F10FB}'

Should these values be added to this manifest? If not, it's okay.

@stephengillie stephengillie added Needs-Author-Feedback This needs a response from the author. and removed Needs-Attention This work item needs to be reviewed by a member of the core team. labels May 13, 2024
@PolarGoose
Copy link
Contributor Author

It is ok not to add them. These fields are optional.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels May 13, 2024
@stephengillie
Copy link
Collaborator

stephengillie commented May 13, 2024

Edit: Sorry, using the wrong automation tool.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label May 13, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 360954f into microsoft:master May 13, 2024
8 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label May 13, 2024
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Manifest-Metadata-Consistency Moderator-Approved One of the Moderators has reviewed and approved this PR Needs-Attention This work item needs to be reviewed by a member of the core team. Needs-Author-Feedback This needs a response from the author. New-Manifest Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants