Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: distinguish Date frequency in extract_date_range() #131

Closed
martinctc opened this issue Apr 15, 2021 · 1 comment · Fixed by #229
Closed

Feature request: distinguish Date frequency in extract_date_range() #131

martinctc opened this issue Apr 15, 2021 · 1 comment · Fixed by #229
Labels
enhancement New feature or request

Comments

@martinctc
Copy link
Member

Currently, extract_date_range() assumes that the data is grouped at a weekly level, but this is not necessarily the case.

It would be good if it computes whether the date is grouped at a daily, weekly, or monthly level, perhaps by taking into account the differences of the dates.

The "text" return could then be something like:

  • Daily data from X to X
  • Weekly data from X to X

When introducing this feature, it would be good to test whether this has an impact on the performance of functions which use extract_date_range().

@martinctc martinctc added the enhancement New feature or request label Apr 15, 2021
@martinctc
Copy link
Member Author

This should also enable a logical return so that this can be used in conditionals, e.g. functions fail if it is not a weekly data, etc. (some reports may be designed for weekly queries, and not for other date frequencies)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant