Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes missing snippets using alternate alternate keys. #1690

Merged
merged 2 commits into from
Jul 27, 2023
Merged

Fixes missing snippets using alternate alternate keys. #1690

merged 2 commits into from
Jul 27, 2023

Conversation

andrueastman
Copy link
Member

Examples with alternate paths fail to get generates or are not correctly generates as the alternate path keys are not added to the pathParameters collection in the Snippet code graph. The snippets are therefore generated with incorrect/missing arguments or fail.

This PR unblocks snippet generation in the doc pages such as
https://learn.microsoft.com/en-us/graph/api/application-get?view=graph-rest-1.0&tabs=csharp#example-2-retrieve-an-application-by-its-appid-and-only-specific-properties

@andrueastman andrueastman marked this pull request as ready for review July 27, 2023 09:26
@andrueastman andrueastman requested a review from a team as a code owner July 27, 2023 09:26
@andrueastman andrueastman enabled auto-merge (squash) July 27, 2023 09:26
@andrueastman andrueastman requested a review from baywet July 27, 2023 15:44
@sonarcloud
Copy link

sonarcloud bot commented Jul 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@andrueastman andrueastman merged commit 9629514 into dev Jul 27, 2023
9 checks passed
@andrueastman andrueastman deleted the andrueastman/alternatePathSnippets branch July 27, 2023 16:34
SilasKenneth added a commit that referenced this pull request Jul 31, 2023
@SilasKenneth @andrueastman
Latest Dev changes (#1694)
33663a6 
* Fixes missing snippets due to alternate keys. (#1690)

* Fix issue with writing DateOnly and TimeOnly properties. (#1693)

---------

Co-authored-by: Eastman <andrueastman@users.noreply.github.com>
@SilasKenneth SilasKenneth mentioned this pull request Aug 15, 2023
Merged
SilasKenneth added a commit that referenced this pull request Aug 15, 2023
@SilasKenneth @millicentachieng @andrueastman
Latest Dev changes (#1694) (#1711)
349f6a5 
* Fixes missing snippets due to alternate keys. (#1690)

* Fix issue with writing DateOnly and TimeOnly properties. (#1693)

---------

Co-authored-by: Millicent Achieng <achieng.milli@gmail.com>
Co-authored-by: Eastman <andrueastman@users.noreply.github.com>
@SilasKenneth SilasKenneth mentioned this pull request Aug 15, 2023
Merged
SilasKenneth added a commit that referenced this pull request Aug 15, 2023
@SilasKenneth @millicentachieng @andrueastman
Latest Dev changes (#1694) (#1713)
b8d35c6 
* Fixes missing snippets due to alternate keys. (#1690)

* Fix issue with writing DateOnly and TimeOnly properties. (#1693)

---------

Co-authored-by: Millicent Achieng <achieng.milli@gmail.com>
Co-authored-by: Eastman <andrueastman@users.noreply.github.com>
@SilasKenneth SilasKenneth mentioned this pull request Aug 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andrueastman @baywet