Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with writing DateOnly and TimeOnly properties. #1693

Merged
merged 3 commits into from
Jul 28, 2023
Merged

Fix issue with writing DateOnly and TimeOnly properties. #1693

merged 3 commits into from
Jul 28, 2023

Conversation

SilasKenneth
Copy link
Member

Overview

Brief description of what this PR does, and why it is needed.

Demo

Optional. Screenshots, curl examples, etc.

Notes

Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.

Testing Instructions

  • How to test this PR
  • Prefer bulleted description
  • Start after checking out this branch
  • Include any setup required, such as bundling scripts, restarting services, etc.
  • Include test case, and expected output

@SilasKenneth SilasKenneth requested a review from a team as a code owner July 27, 2023 21:45
@SilasKenneth SilasKenneth self-assigned this Jul 27, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

85.7% 85.7% Coverage
0.0% 0.0% Duplication

@SilasKenneth SilasKenneth merged commit fe5ef68 into dev Jul 28, 2023
9 checks passed
@SilasKenneth SilasKenneth deleted the fix/php-snippets-date branch July 28, 2023 13:30
SilasKenneth added a commit that referenced this pull request Jul 31, 2023
@SilasKenneth @andrueastman
Latest Dev changes (#1694)
33663a6 
* Fixes missing snippets due to alternate keys. (#1690)

* Fix issue with writing DateOnly and TimeOnly properties. (#1693)

---------

Co-authored-by: Eastman <andrueastman@users.noreply.github.com>
@SilasKenneth SilasKenneth mentioned this pull request Aug 15, 2023
Merged
SilasKenneth added a commit that referenced this pull request Aug 15, 2023
@SilasKenneth @millicentachieng @andrueastman
Latest Dev changes (#1694) (#1711)
349f6a5 
* Fixes missing snippets due to alternate keys. (#1690)

* Fix issue with writing DateOnly and TimeOnly properties. (#1693)

---------

Co-authored-by: Millicent Achieng <achieng.milli@gmail.com>
Co-authored-by: Eastman <andrueastman@users.noreply.github.com>
@SilasKenneth SilasKenneth mentioned this pull request Aug 15, 2023
Merged
SilasKenneth added a commit that referenced this pull request Aug 15, 2023
@SilasKenneth @millicentachieng @andrueastman
Latest Dev changes (#1694) (#1713)
b8d35c6 
* Fixes missing snippets due to alternate keys. (#1690)

* Fix issue with writing DateOnly and TimeOnly properties. (#1693)

---------

Co-authored-by: Millicent Achieng <achieng.milli@gmail.com>
Co-authored-by: Eastman <andrueastman@users.noreply.github.com>
@SilasKenneth SilasKenneth mentioned this pull request Aug 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman approved these changes

Assignees

@SilasKenneth SilasKenneth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SilasKenneth @andrueastman