Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/Enable screen reader confirmation feedback #802

Merged
merged 16 commits into from
Jan 20, 2021
Merged

fix/Enable screen reader confirmation feedback #802

merged 16 commits into from
Jan 20, 2021

Conversation

ElinorW
Copy link
Collaborator

@ElinorW ElinorW commented Jan 18, 2021 •
edited
Loading

Overview

Screen reader conveys confirmation feedback after successfully :

  • adding 'Key' and 'Value' to the table present in the Request headers tab.
  • deleting 'Key' and 'Value' on the table present in the Request headers tab.
  • activating and deactivating 'Minimize sidebar button'
  • activating the 'Expand' button in the Response area tab items.

fixes #796

Testing Instructions

  1. Launch Narrator.
  2. Open the URL in Anaheim edge dev browser.
  3. Navigate to the 'Request headers' tab present in the right side of the pane and activate it. 'Request headers' section will open.
  4. Navigate and fill the required details in the 'Key' and 'Value' edit box.
  5. Navigate to the 'Add' button and activate it using enter key. Values of the 'Key' and 'Value' edit boxes gets successfully added in the table.
  6. Observe the screen reader message.
  7. Observe similar response upon deletion of the 'Key' and 'Value' Item.
  8. Observe feedback on activating the 'Minimize sidebar button' and 'Expand' button

thewahome
thewahome reviewed Jan 18, 2021
View reviewed changes
src/app/views/App.tsx Outdated
@@ -66,6 +68,7 @@ interface IAppState {
selectedVerb: string;
mobileScreen: boolean;
hideDialog: boolean;
onToggleSidebar: boolean;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This variable is named like an event. Changing it to isSidebarToggled may help clarify it's purpose

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah true, will do

thewahome
thewahome requested changes Jan 18, 2021
View reviewed changes
src/app/views/App.tsx Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-802.centralus.azurestaticapps.net

1 similar comment
@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-802.centralus.azurestaticapps.net

@thewahome thewahome self-requested a review January 18, 2021 17:19
@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-802.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-802.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-802.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-802.centralus.azurestaticapps.net

@ElinorW ElinorW requested a review from jobala January 20, 2021 07:28
@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-802.centralus.azurestaticapps.net

@ElinorW ElinorW merged commit 5bf4550 into dev Jan 20, 2021
@ElinorW ElinorW deleted the fix/screen-reader-support branch January 20, 2021 08:32
thewahome added a commit that referenced this pull request Jan 30, 2021
@thewahome @jobala
@OfficeGlobal @msftgits @ElinorW @millicentachieng @sebastienlevert @ezkemboi @baywet @Kachulio1
chore(release): 4.2.0 (#820)
5207e09 
* Fix - replaces content-type header by accept to match HTTP and avoid CORS pre-flight (#783)

* Fix: modify permissions tab UI (#790)

* Track errors  (#777)

* Fix: sanitize url when fetching permissions (#794)

* Fix: remove wrongly placed working (#795)

* Fix: all permissions show as required (#797)

* Task: autocomplete hover styling (#801)

* Fix: Enable screen reader confirmation feedback (#802)

* Migrate to eslint (#627)

* Feature: resizable components (#766)

* Fix: add onItemInvoked action (#806)

* Fix: permissions consent (#807)

* Task: accessibility ci (#358)

* Fix: prevent resize when view expanded (#816)

* Feature: additional telemetry (#813)

* Fix: permissions tab UI (#815)

* Fix: shrink request section (#822)

Co-authored-by: jobala <japhethobalak@gmail.com>
Co-authored-by: OfficeGlobal <47977325+OfficeGlobal@users.noreply.github.com>
Co-authored-by: OfficeGlobal <OfficeGlobal@microsoft.com>
Co-authored-by: Azure Static Web Apps <opensource@microsoft.com>
Co-authored-by: Elinor <ekaguongo@gmail.com>
Co-authored-by: Millicent Achieng <achieng.milli@gmail.com>
Co-authored-by: Sébastien Levert <sebastienlevert@users.noreply.github.com>
Co-authored-by: Ezrqn Kemboi <ezrqnkemboi@gmail.com>
Co-authored-by: Vincent Biret <vibiret@microsoft.com>
Co-authored-by: Joseph Ngugi <jngugi88@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jobala jobala jobala approved these changes

@thewahome thewahome thewahome approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ElinorW @jobala @thewahome