Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track errors #777

Merged
merged 20 commits into from
Jan 13, 2021
Merged

Track errors #777

merged 20 commits into from
Jan 13, 2021

Conversation

millicentachieng
Copy link
Contributor

Overview

This PR aims to add functionality for collecting error data within the app.

Here's an example of how we capture error data for a link that failed to op

telemetry.trackException(
  new Error(LINK_ERROR), 
  SeverityLevel.Error, 
  {
    ComponentName: 'Documentation link',
    SampleId: 'ef1b25b4-e6c7-4e91-88a1-6358f5fff714',
    Link: 'https://developer.microsoft.com/en-us/graph/docs/api-reference/v1.0/resources/users'
  });

The categories of errors to be captured will be:

  • LINK_ERROR
    Errors in external links that have been malformed or that return status code that do not indicate success
  • COMPONENT_ERROR
    Errors when a component fails to render
  • NETWORK_ERROR
    Errors from HTTP requests
  • OPERATIONAL_ERROR
    Any other errors caught within code that are temporary e.g. those originating from user input

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2020

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-777.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2020

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-777.centralus.azurestaticapps.net

@ddyett
Copy link

ddyett commented Jan 12, 2021

is there a blocker on getting this in?

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-777.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-777.centralus.azurestaticapps.net

@millicentachieng millicentachieng merged commit 89121d6 into dev Jan 13, 2021
@millicentachieng millicentachieng deleted the feature/telemetry-errors branch January 13, 2021 03:18
thewahome added a commit that referenced this pull request Jan 30, 2021
* Fix - replaces content-type header by accept to match HTTP and avoid CORS pre-flight (#783)

* Fix: modify permissions tab UI (#790)

* Track errors  (#777)

* Fix: sanitize url when fetching permissions (#794)

* Fix: remove wrongly placed working (#795)

* Fix: all permissions show as required (#797)

* Task: autocomplete hover styling (#801)

* Fix: Enable screen reader confirmation feedback (#802)

* Migrate to eslint (#627)

* Feature: resizable components (#766)

* Fix: add onItemInvoked action (#806)

* Fix: permissions consent (#807)

* Task: accessibility ci (#358)

* Fix: prevent resize when view expanded (#816)

* Feature: additional telemetry (#813)

* Fix: permissions tab UI (#815)

* Fix: shrink request section (#822)

Co-authored-by: jobala <japhethobalak@gmail.com>
Co-authored-by: OfficeGlobal <47977325+OfficeGlobal@users.noreply.github.com>
Co-authored-by: OfficeGlobal <OfficeGlobal@microsoft.com>
Co-authored-by: Azure Static Web Apps <opensource@microsoft.com>
Co-authored-by: Elinor <ekaguongo@gmail.com>
Co-authored-by: Millicent Achieng <achieng.milli@gmail.com>
Co-authored-by: Sébastien Levert <sebastienlevert@users.noreply.github.com>
Co-authored-by: Ezrqn Kemboi <ezrqnkemboi@gmail.com>
Co-authored-by: Vincent Biret <vibiret@microsoft.com>
Co-authored-by: Joseph Ngugi <jngugi88@gmail.com>
@thewahome thewahome linked an issue Feb 9, 2021 that may be closed by this pull request
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Track errors in GE v4
5 participants