Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/accessibility ci #358

Merged
merged 88 commits into from
Jan 26, 2021
Merged

Task/accessibility ci #358

merged 88 commits into from
Jan 26, 2021

Conversation

jobala
Copy link
Contributor

@jobala jobala commented Feb 7, 2020

Overview

Automates accessibility checks.

Fixes #791

Testing instructions

  1. Download the latest stable chromedriver from here.
  2. In your .env file, create a variable REACT_APP_CHROMEDRIVER_PATH and save the path to your chromedriver.exe file.
    For example (on a Windows PC) it would be : REACT_APP_CHROMEDRIVER_PATH=C:\\SeleniumWebDrivers\\ChromeDriver\\chromedriver.exe
    Take note of the format.
  3. Save your changes.
  4. On your terminal run the command npm install
  5. Once the installation is complete run the command npm run ci

@jobala jobala marked this pull request as ready for review February 19, 2020 22:14
@jobala jobala closed this Apr 8, 2020
@Shjokie
Copy link
Contributor

Shjokie commented Apr 9, 2020

There's pending work on this PR, reopening it.

@Shjokie Shjokie reopened this Apr 9, 2020
@ddyett
Copy link

ddyett commented Apr 16, 2020

@jobala @thewahome any reason this wasn't checked in? i see there was one test failure.

@jobala
Copy link
Contributor Author

jobala commented May 7, 2020

@ddyett I moved to Python before I could finish working on this. Fixing the test failure is the pending work item.

@ddyett
Copy link

ddyett commented May 7, 2020

@ddyett I moved to Python before I could finish working on this. Fixing the test failure is the pending work item.

ok let's discuss when we can fit this one in

@ddyett ddyett requested review from a team and ddyett and removed request for a team June 2, 2020 18:18
// @ts-ignore
const accessibilityScanResults = await AxeBuilder(driver)
.disableRules(['landmark-one-main', 'region']) // disabled as main landmark already exists on live site
.analyze();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where can i find what's actually being analyzed?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-358.centralus.azurestaticapps.net

1 similar comment
@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-358.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-358.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-358.centralus.azurestaticapps.net

1 similar comment
@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-358.centralus.azurestaticapps.net

test-report.xml Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-358.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-358.centralus.azurestaticapps.net

1 similar comment
@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-358.centralus.azurestaticapps.net

@ElinorW ElinorW merged commit b8b0807 into dev Jan 26, 2021
thewahome added a commit that referenced this pull request Jan 30, 2021
* Fix - replaces content-type header by accept to match HTTP and avoid CORS pre-flight (#783)

* Fix: modify permissions tab UI (#790)

* Track errors  (#777)

* Fix: sanitize url when fetching permissions (#794)

* Fix: remove wrongly placed working (#795)

* Fix: all permissions show as required (#797)

* Task: autocomplete hover styling (#801)

* Fix: Enable screen reader confirmation feedback (#802)

* Migrate to eslint (#627)

* Feature: resizable components (#766)

* Fix: add onItemInvoked action (#806)

* Fix: permissions consent (#807)

* Task: accessibility ci (#358)

* Fix: prevent resize when view expanded (#816)

* Feature: additional telemetry (#813)

* Fix: permissions tab UI (#815)

* Fix: shrink request section (#822)

Co-authored-by: jobala <japhethobalak@gmail.com>
Co-authored-by: OfficeGlobal <47977325+OfficeGlobal@users.noreply.github.com>
Co-authored-by: OfficeGlobal <OfficeGlobal@microsoft.com>
Co-authored-by: Azure Static Web Apps <opensource@microsoft.com>
Co-authored-by: Elinor <ekaguongo@gmail.com>
Co-authored-by: Millicent Achieng <achieng.milli@gmail.com>
Co-authored-by: Sébastien Levert <sebastienlevert@users.noreply.github.com>
Co-authored-by: Ezrqn Kemboi <ezrqnkemboi@gmail.com>
Co-authored-by: Vincent Biret <vibiret@microsoft.com>
Co-authored-by: Joseph Ngugi <jngugi88@gmail.com>
@thewahome thewahome deleted the task/accessibility-ci branch February 17, 2021 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create tests to eliminate accessibility issues in Graph Explorer
6 participants