Fix: prevent resize when view expanded #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElinorW
approved these changes
Jan 27, 2021
thewahome
added a commit
that referenced
this pull request
Jan 30, 2021
* Fix - replaces content-type header by accept to match HTTP and avoid CORS pre-flight (#783) * Fix: modify permissions tab UI (#790) * Track errors (#777) * Fix: sanitize url when fetching permissions (#794) * Fix: remove wrongly placed working (#795) * Fix: all permissions show as required (#797) * Task: autocomplete hover styling (#801) * Fix: Enable screen reader confirmation feedback (#802) * Migrate to eslint (#627) * Feature: resizable components (#766) * Fix: add onItemInvoked action (#806) * Fix: permissions consent (#807) * Task: accessibility ci (#358) * Fix: prevent resize when view expanded (#816) * Feature: additional telemetry (#813) * Fix: permissions tab UI (#815) * Fix: shrink request section (#822) Co-authored-by: jobala <japhethobalak@gmail.com> Co-authored-by: OfficeGlobal <47977325+OfficeGlobal@users.noreply.github.com> Co-authored-by: OfficeGlobal <OfficeGlobal@microsoft.com> Co-authored-by: Azure Static Web Apps <opensource@microsoft.com> Co-authored-by: Elinor <ekaguongo@gmail.com> Co-authored-by: Millicent Achieng <achieng.milli@gmail.com> Co-authored-by: Sébastien Levert <sebastienlevert@users.noreply.github.com> Co-authored-by: Ezrqn Kemboi <ezrqnkemboi@gmail.com> Co-authored-by: Vincent Biret <vibiret@microsoft.com> Co-authored-by: Joseph Ngugi <jngugi88@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
If the components are resized and the user clicks the Expand button, the expanded area takes the values of the resize. This PR changes this so that the real estate when the response area is expanded is not affected by the resize action.
Fixes #819
Demo
Optional. Screenshots,
curlexamples, etc.Notes
Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.
Testing Instructions
my mailrequest