Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Autocomplete character selection #2304

Merged
merged 3 commits into from
Jan 12, 2023

Conversation

Onokaev
Copy link
Contributor

@Onokaev Onokaev commented Dec 13, 2022

Overview

#2298

Demo

Optional. Screenshots, curl examples, etc.

Notes

Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.

Testing Instructions

  • How to test this PR
  1. Check out this branch
  2. click in the query bar
  3. type: /messages?$sel
  4. Note that $select is suggested
  5. Press enter
  6. Query bar shows https://graph.microsoft.com/v1.0/me?$select=

@Onokaev Onokaev merged commit b95426f into dev Jan 12, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@thewahome thewahome deleted the fix/autocomplete-parameter-selection branch February 8, 2023 08:35
@github-actions github-actions bot mentioned this pull request Feb 8, 2023
thewahome pushed a commit that referenced this pull request Feb 13, 2023
Feature: add general playwright tests (#2149)

Task: Add Graph Support Info on README.md (#2347)

Task: Add logging for script errors (#2351)

Task: Add language snippet telemetry (#2371)

Task: Rename sample query "all the items in my drive" to "list items in my drive" (#2350)

Fix: Response area container heights (#2372)

Fix: Re-order tests (#2354)

Fix: Inform user if URL is incomplete (#2367)

Fix: Autocollapsing of history items (#2331)

Fix: Screen blanking on render (#2403)

Fix: Add method to filter ResizeObserver exceptions (#2342)

Fix: enter key runs previous query (#2348)

Fix: autocomplete character selection (#2304)

Fix: Display beta resources subgroups for admin group (#2364)

Fix: Update deprecated aria-label (#2368)

Fix: Default overlay on collections review panel (#2377)

Chore: December dependabot upgrades (#2296)

Chore: Dependabot upgrades February (#2401)

chore: Dependabot upgrades (#2335)

Chore: Code cleanup (#2251)
@Onokaev Onokaev mentioned this pull request Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] using the mouse to select a query string parameter results in $$ in url
3 participants