[all] updating components with tsdocs comments to properties, additio… #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nally only people picker has function comments
nmetulev
suggested changes
Aug 21, 2019
There was a problem hiding this comment.
Couple notes:
- Now that we've merged the tslint pr, it should help define which properties, methods, classes, etc need documentation.
- I've noticed you are not documenting classes, enums, etc - make sure you do those as well - tslint should help here (things like private properties and methods are not required for example)
- I've notices you are not documenting all the providers and graph source files, need to make sure everything is documented. If that's the case, ensure you've made that clear in this PR so we ensure we track other source files that need tsdocs
…aph/microsoft-graph-toolkit into nivogt/tsdocs-update
|
@nmetulev please re-review, I'll merge after bug fixes for people-picker |
nmetulev
reviewed
Aug 27, 2019
|
This PR is only documenting the components and that's ok as we are updating the other source files in other PRs. Created #133 to track the rest of the work. Once you have resolved this last one comment, we can merge this |
nmetulev
approved these changes
Aug 28, 2019
shweaver-MSFT
pushed a commit
that referenced
this pull request
Jun 8, 2020
#125) * [all] updating components with tsdocs comments to properties, additionally only people picker has function comments * [mgt-agenda] updating tsdocs * [mgt-login] updating tsdocs * [people] updating ts docs * [people-picker] updating tsdocs * [mgt-person] updating tsdocs * [mgt-tasks] updating tsdocs * [mgt-login] additional ts documentation
shweaver-MSFT
pushed a commit
that referenced
this pull request
Jun 10, 2020
#125) * [all] updating components with tsdocs comments to properties, additionally only people picker has function comments * [mgt-agenda] updating tsdocs * [mgt-login] updating tsdocs * [people] updating ts docs * [people-picker] updating tsdocs * [mgt-person] updating tsdocs * [mgt-tasks] updating tsdocs * [mgt-login] additional ts documentation
shweaver-MSFT
pushed a commit
that referenced
this pull request
Jun 10, 2020
#125) * [all] updating components with tsdocs comments to properties, additionally only people picker has function comments * [mgt-agenda] updating tsdocs * [mgt-login] updating tsdocs * [people] updating ts docs * [people-picker] updating tsdocs * [mgt-person] updating tsdocs * [mgt-tasks] updating tsdocs * [mgt-login] additional ts documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nally only people picker has function comments
PR Type
Refactoring (no functional changes, no api changes)
Documentation content changes
Description of the changes
Adding tsdocs comments to all component properties.
Referencing #115:
PR checklist
Other information