Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: set the endpoint URL for the mock-provider in the session storage #1979

Merged
merged 3 commits into from
Dec 14, 2022
Merged

feat: set the endpoint URL for the mock-provider in the session storage #1979

merged 3 commits into from
Dec 14, 2022

Conversation

musale
Copy link
Contributor

@musale musale commented Dec 8, 2022

Closes #1416

PR Type

  • Feature

Description of the changes

  • Cache the endpoint URL used in the mock provider in the Session storage.

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@musale musale added this to the 2022-12 milestone Dec 8, 2022
@ghost
Copy link

ghost commented Dec 8, 2022

Thank you for creating a Pull Request @musale.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@github-actions
Copy link

github-actions bot commented Dec 8, 2022

The updated storybook is available here

1 similar comment
@github-actions
Copy link

github-actions bot commented Dec 8, 2022

The updated storybook is available here

gavinbarron
gavinbarron requested changes Dec 8, 2022
View reviewed changes
Copy link
Member

@gavinbarron gavinbarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a bit of work to ensure that we don't run into issue if session storage is no available.

packages/mgt-element/src/utils/Session.ts Outdated Show resolved Hide resolved
packages/mgt-element/src/mock/MockGraph.ts Outdated Show resolved Hide resolved
@ghost ghost added the Needs: Author Feedback Issue needs response from issue author label Dec 8, 2022
@github-actions
Copy link

github-actions bot commented Dec 8, 2022

The updated storybook is available here

@ghost ghost removed the Needs: Author Feedback Issue needs response from issue author label Dec 13, 2022
@github-actions
Copy link

The updated storybook is available here

@ghost ghost added the Needs: Author Feedback Issue needs response from issue author label Dec 13, 2022
@github-actions
Copy link

The updated storybook is available here

@ghost ghost removed the Needs: Author Feedback Issue needs response from issue author label Dec 13, 2022
@github-actions
Copy link

The updated storybook is available here

@gavinbarron gavinbarron merged commit b2cbbf2 into main Dec 14, 2022
@gavinbarron gavinbarron deleted the musale/mock-url-session branch December 14, 2022 18:52
This was referenced Jul 17, 2023
Closed
Closed
@gavinbarron gavinbarron mentioned this pull request Jul 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavinbarron gavinbarron gavinbarron approved these changes

@sebastienlevert sebastienlevert sebastienlevert approved these changes

@Mnickii Mnickii Awaiting requested review from Mnickii

Assignees
No one assigned
Labels
Build: Storybook
Projects
Graph Toolkit
Archived in project
Milestone
2022-12
Development

Successfully merging this pull request may close these issues.

[MockProvider] Cache the endpoint Url
3 participants
@musale @gavinbarron @sebastienlevert